renamed testing and added CI for packaging #688
Conversation
PsypherPunk
left a comment
PsypherPunk
left a comment
There was a problem hiding this comment.
I'm attempting to run/emulate the pipelines to validate a few things but have left a few comments/queries.
|
|
|
@PsypherPunk can you please try and get act to run here? If it doesn't work, we will have to do ye olde merge and try 🙃 |
PsypherPunk
left a comment
PsypherPunk
left a comment
There was a problem hiding this comment.
Tested the build-* jobs insofar as I can locally with act.
The only issue is the test job which act doesn't like without rustfmt and clippy being explicitly included.
| with: | ||
| profile: minimal | ||
| toolchain: ${{ matrix.rust }} | ||
| override: true |
There was a problem hiding this comment.
I needed to add components: clippy, rustfmt here to get act --rm --job test to pass.
| jobs: | ||
| test: | ||
| name: Test Suite | ||
| build-nix: |
There was a problem hiding this comment.
This builds but fails at the actions/upload-artifact@v4 stage, as expected.
PsypherPunk
left a comment
PsypherPunk
left a comment
There was a problem hiding this comment.
Validated as much as I think I can. As discussed, the issue with test doesn't currently happen on the master branch so, in the spirit of fixing-forward…
No description provided.